From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 4 commit: Update the runtime to properly support Windows. |
Date: | 2016-02-03 05:24:46 |
Message-ID: | CACCA4P1kaW7Urgfhq2Xy0Nnx8ri6SRwyfHedUmZCQ35O60je9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Below two minor changes.
- We have added below statement two times in Qt project files so removed
the duplicate entry.
PY2_VERSION = $$find(PY_VERSION, "^2")
- Added some instructions in README file for the Windows system.
Can you please review attached patch file and let us know for any comments.
Thanks,
Neel Patel
On Tue, Feb 2, 2016 at 6:46 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Update the runtime to properly support Windows.
>
> Branch
> ------
> master
>
> Details
> -------
>
> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efc8815ecb78b20318d18ba50588e63e554f053a
> Author: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>
> Modified Files
> --------------
> runtime/Server.cpp | 13 +++++++++++--
> runtime/pgAdmin4.pro | 54
> +++++++++++++++++++++++++++++++++++++++++-----------
> 2 files changed, 54 insertions(+), 13 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
Attachment | Content-Type | Size |
---|---|---|
windows_runtime_fix.patch | application/octet-stream | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2016-02-03 06:38:20 | PATCH: NodeAjaxOptionsControl in Subnode |
Previous Message | Ashesh Vashi | 2016-02-03 05:19:42 | Re: [pgAdmin4] Patch: Added new Control SqlFieldControl |