Re: Added variable macro for generic db objects

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Added variable macro for generic db objects
Date: 2016-02-03 11:08:10
Message-ID: CAG7mmoxKjWTLWW9zc+wz6PQK5aq1ngaES0jO4R+cA-eSTfQRcA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Feb 3, 2016 at 3:37 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Ashesh,
>
> PFA updated patch for generic variable macro as per Neel's suggestion, now
> it will take collection instead of single key/value pair.
>
> For example,
>
> options_collection = [
> {*name*: 'Option-1', *value*: 'Value-1'},
> {*name*: 'Option-2', *value*: 'Value-2'},
> {*name*: 'Option-3', *value*: 'Value-3'},
> ]
>
> *Way to use in template:*
>
> VARIABLE.SET(conn, object_type, object_name, options_collection)
> VARIABLE.UNSET(conn, object_type, object_name, options_collection)
>
>
>
> *Result:*
> ALTER DB_OBJ TEST
> SET (Option-1=Value-1, Option-2=Value-2, Option-3=Value-3);
>
> ALTER DB_OBJ TEST
> RESET (Option-1,Option-2,Option-3);
>
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Feb 2, 2016 at 7:46 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Thanks - checked in!
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Tue, Feb 2, 2016 at 6:31 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA updated patch, I missed adding parentheses in previous patch for
>>> UNSET macro .
>>>
>>> Thanks.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Feb 2, 2016 at 5:49 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch to add another generic macro for variable control, previously
>>>> written macro was specific to database node and not usable with other db
>>>> objects.
>>>>
>>>> *How to use:*
>>>> VARIABLE.SET(conn, object_type, object_name, variable_name, value)
>>>> VARIABLE.UNSET(conn, object_type, object_name, variable_name)
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2016-02-03 11:11:11 Re: PATCH: Tablespace Node [pgAdmin4]
Previous Message Ashesh Vashi 2016-02-03 11:07:28 pgAdmin 4 commit: Modified the variable jinja2 macros to allow to set/r