Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
Date: 2017-02-01 14:22:22
Message-ID: CAKKotZQf1rAx=GgDtDUQwjxbg1xJ7Pnh9Bf9M-Rut+_Rq4Kz9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks Dave.

Tested and working fine.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Feb 1, 2017 at 7:20 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA minor patch to display value '0' in Read only text editor.
> > RM#2138
>
> Thanks - I committed a modified version of the patch; yours had the
> same tests duplicated and joined with an or conditional.
>
> Please double check it's OK - it looks fine to me and seems to work as
> expected with null, zero and one.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message David Wanner 2017-02-02 04:31:43 pg3 vs pg4 for macOS
Previous Message Dave Page 2017-02-01 13:50:17 Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor