Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
Date: 2017-02-01 13:50:17
Message-ID: CA+OCxozGO_QH-sXBjKR-S5kmN+q3n__qR0rbft0KmMts-t-t0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Feb 1, 2017 at 12:18 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA minor patch to display value '0' in Read only text editor.
> RM#2138

Thanks - I committed a modified version of the patch; yours had the
same tests duplicated and joined with an or conditional.

Please double check it's OK - it looks fine to me and seems to work as
expected with null, zero and one.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-02-01 14:22:22 Re: [pgAdmin4][Patch] Displaying Zero in Slickgrid editor
Previous Message Dave Page 2017-02-01 13:49:01 pgAdmin 4 commit: Fix display of zeros in read-only grid editors. Fixes