Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
Date: 2018-03-15 12:30:07
Message-ID: CAKKotZQOT61K1W-MVBsoF8BPcUyF5+yEakz-uSX4G=L3ogdqTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> I have just noticed, we're ignoring migrations directory too.
>> Should we not also check code styling for migrations directory?
>>
>
> Yeah, I was going to ask about that :-). Is there a specific reason why
> we're ignoring the migrations Murtuza?
>
​To ease writing long SQL's.

>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>
>>> Modified Files
>>> --------------
>>> web/.pycodestyle | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-03-15 16:12:58 Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
Previous Message pgAdmin 4 Jenkins 2018-03-15 12:19:17 Jenkins build is back to normal : pgadmin4-master-python27 #532