Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
Date: 2018-03-15 11:23:39
Message-ID: CA+OCxowU18WyHVM5k5xUAU4V0kQkLNnVG8tk9e3-O6Vcu_d3aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi,
>
> I have just noticed, we're ignoring migrations directory too.
> Should we not also check code styling for migrations directory?
>

Yeah, I was going to ask about that :-). Is there a specific reason why
we're ignoring the migrations Murtuza?

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>
>> Modified Files
>> --------------
>> web/.pycodestyle | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2018-03-15 11:34:35 Jenkins build is back to normal : pgadmin4-master-python36 #522
Previous Message pgAdmin 4 Jenkins 2018-03-15 11:23:27 Jenkins build is back to normal : pgadmin4-master-python26 #657