Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn

On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> I have just noticed, we're ignoring migrations directory too.
>>> Should we not also check code styling for migrations directory?
>>>
>>
>> Yeah, I was going to ask about that :-). Is there a specific reason why
>> we're ignoring the migrations Murtuza?
>>
> ​To ease writing long SQL's.
>
>

Perhaps we could just skip the long line check for those files?

>
>>
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>>
>>>> Branch
>>>> ------
>>>> master
>>>>
>>>> Details
>>>> -------
>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>>
>>>> Modified Files
>>>> --------------
>>>> web/.pycodestyle | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company