Re: Fix in switch cell tab navigation

From: Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fix in switch cell tab navigation
Date: 2020-03-26 05:00:22
Message-ID: CAK6syAoHoF3iQdd53_acRnx+6b9+MOEK=sq7AbaqeVf5aCKERQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Khushboo,

I have removed the condition added for subgrid-cell. Please find the
attached updated patch

Regards,
Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Ganesh,
>
> You have put a check on *subgrid-cell* class, which does not exist in the
> entire source code.
> Also, can you please let me know of any module which you have tested, so I
> can test accordingly though the code for the same looks good to me.
>
> Thanks,
> Khushboo
>
>
> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <
> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for below minor fix in the switch cell tab
>> navigation:
>>
>> After pressing the tab key on switch cell, sometimes focus doesn't go to
>> the immediate next editable cell. It goes to the different cell for
>> fraction of seconds and again comes to the next editable cell.
>>
>> Please review.
>>
>> Regards,
>> Ganesh Jaybhay
>>
>

Attachment Content-Type Size
switch_cell_navigation_v1.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-03-26 05:20:11 pgAdmin 4 commit: Fixed an issue where focus doesn't go to the immediat
Previous Message Aditya Toshniwal 2020-03-26 04:53:23 Re: [pgAdmin][RM5292] Alertify header buttons focus color issue