From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Ganesh Jaybhay <ganesh(dot)jaybhay(at)enterprisedb(dot)com> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix in switch cell tab navigation |
Date: | 2020-03-26 05:20:57 |
Message-ID: | CANxoLDdreG4TecTxirN=_d7XaD0qpV_bd5Lc9+j8VFbnZrsH1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Thu, Mar 26, 2020 at 10:30 AM Ganesh Jaybhay <
ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
> Hi Khushboo,
>
> I have removed the condition added for subgrid-cell. Please find the
> attached updated patch
>
> Regards,
> Ganesh Jaybhay
>
> On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Ganesh,
>>
>> You have put a check on *subgrid-cell* class, which does not exist in
>> the entire source code.
>> Also, can you please let me know of any module which you have tested, so
>> I can test accordingly though the code for the same looks good to me.
>>
>> Thanks,
>> Khushboo
>>
>>
>> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <
>> ganesh(dot)jaybhay(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for below minor fix in the switch cell tab
>>> navigation:
>>>
>>> After pressing the tab key on switch cell, sometimes focus doesn't go to
>>> the immediate next editable cell. It goes to the different cell for
>>> fraction of seconds and again comes to the next editable cell.
>>>
>>> Please review.
>>>
>>> Regards,
>>> Ganesh Jaybhay
>>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Nagesh Dhope | 2020-03-26 05:29:47 | Re: [pgAdmin][RM5292] Alertify header buttons focus color issue |
Previous Message | Akshay Joshi | 2020-03-26 05:20:11 | pgAdmin 4 commit: Fixed an issue where focus doesn't go to the immediat |