| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM5292] Alertify header buttons focus color issue |
| Date: | 2020-03-26 04:53:23 |
| Message-ID: | CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Nagesh,
I cannot see any change related to $active-border variable apart from
!default. Plus, $active-border should not be allowed to edit. It is a
structural variable and not a variable which affects theme change.
Please revert the $active-border change and send the patch.
On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>
wrote:
> Hi Hackers,
>
> Please find a patch which includes
>
> 1. Use *btn-secondary* styles for all buttons in alertify dialog
> header.
> 2. Added *!default *for $active-border variable, so that it can be
> overridden if required.
> 3. Added entry for *.scss *in .editorconfig
>
> --
> Thanks,
> Nagesh
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ganesh Jaybhay | 2020-03-26 05:00:22 | Re: Fix in switch cell tab navigation |
| Previous Message | Nagesh Dhope | 2020-03-26 04:44:27 | [pgAdmin][RM5292] Alertify header buttons focus color issue |