| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Fix an incorrect statement for failover option in alter_subscription.sgml |
| Date: | 2024-07-22 05:15:14 |
| Message-ID: | CAJpy0uCgW5__OQPxu0CgrK5inAHzX7rqNThuzHZS3Yr0_XKkhQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> The documentation incorrectly stated that users cannot alter subscription's
> failover option when two-phase commit is enabled.
>
> When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET
> (failover) in a transaction block, but I missed the following statement for
> two-phase commit which causes the incorrect understanding. Here is a small
> patch to fix it.
The patch looks good to me except there is repetition of commands in
both the lines now. But I could not think of a better way. So I think
it is okay to have this way.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-07-22 05:16:53 | Correction in doc of failover ready steps |
| Previous Message | PG Doc comments form | 2024-07-21 09:52:13 | Undocumented count in FORWARD/BACKWARD direction of MOVE statement |