Re: Fix an incorrect statement for failover option in alter_subscription.sgml

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix an incorrect statement for failover option in alter_subscription.sgml
Date: 2024-07-22 10:54:55
Message-ID: CAA4eK1JAiTOFpwSjgQsPKJ-CSW=YAAG8+hR69+zAHAuaUnbiyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Mon, Jul 22, 2024 at 10:45 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Fri, Jul 19, 2024 at 10:43 AM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Hi,
> >
> > The documentation incorrectly stated that users cannot alter subscription's
> > failover option when two-phase commit is enabled.
> >
> > When writing this doc, I only wanted to mention we cannot execute ALTER SUB SET
> > (failover) in a transaction block, but I missed the following statement for
> > two-phase commit which causes the incorrect understanding. Here is a small
> > patch to fix it.
>
> The patch looks good to me except there is repetition of commands in
> both the lines now. But I could not think of a better way. So I think
> it is okay to have this way.
>

Thanks for the review. I also couldn't think of a better way to
document this information. The patch as proposed looks good to me.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Amit Kapila 2024-07-22 11:12:55 Re: Correction in doc of failover ready steps
Previous Message PG Doc comments form 2024-07-22 08:00:26 Undocumented := alternative in using option of raise statement