Re: unused_oids script is broken with bsd sed

From: John Naylor <jcnaylor(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unused_oids script is broken with bsd sed
Date: 2018-04-25 18:14:08
Message-ID: CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/25/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> +many for rewriting in perl. Do you want to have a go at that? If not I
>> will.
>
> +1 ... I was mildly astonished that this didn't already have to happen
> as part of the bootstrap data conversion effort. It's certainly not
> hard to imagine future extensions to the .dat file format that would
> break this script, and duplicate_oids too. I think we should rewrite
> both of them to use the Catalog.pm infrastructure.

If we're going to use Catalog.pm for that, it seems more convenient to
expose toast and index oids directly rather than in strings formatted
specifically for the bki file, as in the attached. Thoughts?

-John Naylor

Attachment Content-Type Size
expose-toast-and-index-oids.patch text/x-patch 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-04-25 18:15:22 Re: wal_consistency_checking reports an inconsistency on master branch
Previous Message Tom Lane 2018-04-25 18:01:29 Re: perltidy version