| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <jcnaylor(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unused_oids script is broken with bsd sed |
| Date: | 2018-04-25 18:26:35 |
| Message-ID: | 9426.1524680795@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <jcnaylor(at)gmail(dot)com> writes:
> On 4/25/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think we should rewrite
>> both of them to use the Catalog.pm infrastructure.
> If we're going to use Catalog.pm for that, it seems more convenient to
> expose toast and index oids directly rather than in strings formatted
> specifically for the bki file, as in the attached. Thoughts?
Good idea, I like this better than what Stas did in his patch.
I'm a bit inclined to preserve the old variable names (toast_name,
toast_oid etc) as the hash keys because they seem more greppable
than the generic "oid", "name" that you have here. But maybe that
isn't an interesting consideration.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-04-25 18:27:58 | Re: Postgres stucks in deadlock detection |
| Previous Message | Robert Haas | 2018-04-25 18:23:42 | Re: [FEATURE PATCH] pg_stat_statements with plans (v02) |