Re: psqlodbc - SysTAble Prefixes issue

From: brajmohan saxena <braj(dot)saxena(at)gmail(dot)com>
To: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: psqlodbc - SysTAble Prefixes issue
Date: 2016-11-15 08:21:13
Message-ID: CAJLMyc+nmBcwdNbrexynVb9PsxFt6JtEfUt8V=5+BLhU-fwQVQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

I feel this is introduces to consider some default *ExtraSysTablePrefixes *I
am not sure in which case it will be used. As for as i understand there
will be no User specific system table considered in Postgres prefixing with
"dd_". So there is no point to keep this extra psqlODBC config parameter in
future.

I can find it only at the following two places in the psqlodbc branch

*1) in dlg_specific.h*

* #define DEFAULT_EXTRASYSTABLEPREFIXES "dd_"*

*2) In dlg_specific.c *

/* Extra Systable prefixes */

/*
* Use @@@ to distinguish between blank extra prefixes and no key
* entry
*/
SQLGetPrivateProfileString(section, INI_EXTRASYSTABLEPREFIXES,
"@@@",
temp,
sizeof(temp), filename);
if (strcmp(temp, "@@@"))
strcpy(comval->extra_systable_prefixes, temp);
else if (inst_position)
strcpy(comval->extra_systable_prefixes,
*DEFAULT_EXTRASYSTABLEPREFIXES*);

mylog("ci=%p globals.extra_systable_prefixes = '%s'\n", ci,
comval->extra_systable_prefixes);

On Wed, Oct 19, 2016 at 1:48 PM, Tsunakawa, Takayuki <
tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:

> From: pgsql-odbc-owner(at)postgresql(dot)org
> > [mailto:pgsql-odbc-owner(at)postgresql(dot)org] On Behalf Of Heikki Linnakangas
> > I think we should remove the dd_ prefix from the default. Whatever it was
> > originally used for, it's clearly obsolete at this point.
>
> Stepping further, why don't we remove the ExtraSysTablePrefixes
> parameter? I think we should simplify the driver usage for users by
> reducing the number of parameters, as well as reduce the code for psqlODBC
> developers. I can understand the concern for incompatibility, but it's not
> sound to retain things of no good use.
>
> I wonder whether EnterpriseDB uses this parameter for Oracle compatibility.
>
> Regards
> Takayuki Tsunakawa
>
>
>

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Adrian Klaver 2016-11-15 15:49:03 Re: Daylight saving time rules being applied to DateTimes that don't have a timezone
Previous Message Germán Valdez 2016-11-11 10:39:10 error conection Provider=MSDASQL