Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

On Wed, Mar 19, 2025 at 9:06 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Mar 19, 2025 at 2:11 AM David G. Johnston
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> >
> > On Tue, Mar 18, 2025 at 4:47 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >>
> >> I don't understand --dry-run part of conversation here. As per
> >> existing code (or with the patch), we seem to be already printing the
> >> publications to be dropped in dry-run mode.
> >
> >
> > Sorry, that was me making a bad assumption rather than checking first.
> >
> >
> > I'm still bothered by the last paragraph of the commit message saying to backup these publications when the preceding one claims strongly and unconditionally that they are redundant and serve no purpose.
> >
>
> Agreed. I suggest we remove that part of the paragraph (Users should
> back up any manually created publications before running this command.
> By default, publications are preserved to avoid unintended data loss.)
> from the commit message.
>

I have updated the commit message according to the suggestions. The
part about backing up manually created publications has been removed
to align with the statement that they are redundant and serve no
purpose.

The attached patch at [1] contains the suggested changes.

[1] - https://www.postgresql.org/message-id/CAHv8RjJNE1ZvWhsgL54iPsJhomhcG%2B-SGPN8AnnwdLmWt6A44A%40mail.gmail.com

Thanks and regards,
Shubham Khanna.