| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Date: | 2025-03-19 03:36:01 |
| Message-ID: | CAA4eK1JHGJ=Z0ghQMAyxD7jO84Y7Ab-uwcOfid3NvBNxr377kA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 19, 2025 at 2:11 AM David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Tue, Mar 18, 2025 at 4:47 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> I don't understand --dry-run part of conversation here. As per
>> existing code (or with the patch), we seem to be already printing the
>> publications to be dropped in dry-run mode.
>
>
> Sorry, that was me making a bad assumption rather than checking first.
>
>
> I'm still bothered by the last paragraph of the commit message saying to backup these publications when the preceding one claims strongly and unconditionally that they are redundant and serve no purpose.
>
Agreed. I suggest we remove that part of the paragraph (Users should
back up any manually created publications before running this command.
By default, publications are preserved to avoid unintended data loss.)
from the commit message.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sungwoo Chang | 2025-03-19 03:46:30 | Re: like pg_shmem_allocations, but fine-grained for DSM registry ? |
| Previous Message | Sami Imseih | 2025-03-19 03:21:01 | Re: making EXPLAIN extensible |