Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

On Tue, Jan 21, 2025 at 8:10 AM Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
>
> Hi Peter,
>
> Peter Smith <smithpb2250(at)gmail(dot)com> writes:
>
> > On Fri, Dec 13, 2024 at 5:03 AM Dagfinn Ilmari Mannsåker
> > <ilmari(at)ilmari(dot)org> wrote:
> >>
> >> On Thu, 12 Dec 2024, at 17:52, Andrew Dunstan wrote:
> >> > On 2024-12-12 Th 12:08 PM, Dagfinn Ilmari Mannsåker wrote:
> >> >>
> >> >> command_ok(
> >> >> [
> >> >> 'pg_dump',
> >> >> ('--schema', 'pg_catalog'),
> >> >> ('-f', $outputdir . '/catalogs_primary.dump'),
> >> >> '--no-sync',
> >> >> ('-p', $node_primary->port),
> >> >> '--no-unlogged-table-data',
> >> >> 'regression'
> >> >> ],
> >> >> 'dump catalogs of primary server');
> >> >>
> >> >> I think the fat comma is much nicer than this, so I'd like to convert
> >> >> these too (and replace some of the concatenations with interpolation).
> >> >>
> >> >> Technically the quotes aren't necessary around single-dash options
> >> >> before => since unary minus works on strings as well as numbers, but
> >> >> I'll leave them in for consistency.
> >> >
> >> > I'd rather get rid of those and just use the long options.
> >>
> >> Yeah, that is more self-documenting, so I'll do that while I'm at it.
> >>
> >
> > Hi. This thread has been silent for 1 month. Just wondering, has any
> > progress been made on these changes?
>
> I did most of the work shortly after the above post, but then I got
> distracted by Christmas holidays and kind of forgot about it when I got
> back.
>
> Here's a pair of patches. The first one is just running perltidy on the
> current tree so we have a clean slate to see the changes induced by the
> fat comma and long option changes.
>
> - ilmari

I applied the v5* patches and ran make check-world. All passed OK.

Your fat comma changes have greatly improved readability, particularly
in 040_createsubscriber (the file that caused me to start this
thread). Thanks!

======
Kind Regards,
Peter Smith.
Fujitsu Australia