Re: Statistics Import and Export

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: Statistics Import and Export
Date: 2025-01-20 23:31:27
Message-ID: b40b81d38c3a87fdef61e4f7abfbc7f27c7fbcd9.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2025-01-20 at 16:45 -0500, Corey Huinker wrote:
>
> What I struggle to understand is how that purpose isn't served better
> by statistics being in SECTION_NONE like COMMENTs are, so that they
> are imported immediately after the object that they reference.

Tom, you expressed the strongest opinions on this point, can you expand
a bit?

If I understand correctly:

* We strongly want stats to be exported by default[1].

* Adding a SECTION_STATS could work, but would be non-trivial and might
break expectations about the set of sections available[2].

* SECTION_NONE doesn't seem right. There would be no way to get the
stats using --section. Also, if there is no section boundary for the
stats, then couldn't they appear in a surprising order?

* I'm not sure about placing stats in SECTION_POST_DATA. That doesn't
seem terrible to me, but not great either.

* I'm also not 100% sure about the flags. The default should dump the
stats, of course. And I like the idea of allowing any combination of
schema, data and stats to be exported. But that leaves a wrinkle for --
data-only, which (as of v38) does not dump stats, because stats are a
third kind of thing. Perhaps stats should be expressed as a subtype of
data somehow, but I'm not sure exactly how.

Regards,
Jeff Davis

[1]
https://www.postgresql.org/message-id/3228677.1713844341%40sss.pgh.pa.us

[2]
https://www.postgresql.org/message-id/3156140.1713817153%40sss.pgh.pa.us

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Maciek Sakrejda 2025-01-21 00:18:44 Re: [PATCH] Add roman support for to_number function
Previous Message Peter Smith 2025-01-20 23:31:01 Re: pg_createsubscriber TAP test wrapping makes command options hard to read.