| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Euler Taveira" <euler(dot)taveira(at)enterprisedb(dot)com> |
| Subject: | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |
| Date: | 2025-01-20 23:15:54 |
| Message-ID: | 0f90c5bd-e71f-49ec-ab80-ba2008be5c37@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 20, 2025, at 7:49 PM, Tom Lane wrote:
> "Euler Taveira" <euler(at)eulerto(dot)com> writes:
> > It is kind of annoying to keep version 20230309 around to run perltidy. Do we
> > have any other alternatives?
>
> As it says in src/tools/pgindent/README:
>
> 2) Install perltidy. Please be sure it is version 20230309 (older and newer
> versions make different formatting choices, and we want consistency).
>
> I don't think anyone is especially wedded to 20230309 in particular,
> but we don't want different developers using different versions and
> coming out with different results. The whole point of this effort
> is to standardize code layout as best we can, so that would be
> counterproductive.
I can live with that.
> Do you have a strong argument for switching to some other specific
> version of perltidy?
>
I don't. Let's see if the Dagfinn's patch will maintain more stable formatting
over the years. I tested in a previous version (20220613) after applying the
patch and it didn't suggest changes.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-01-20 23:31:01 | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |
| Previous Message | Jeff Davis | 2025-01-20 23:02:49 | Re: Statistics Import and Export |