| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |
| Date: | 2024-07-18 00:09:05 |
| Message-ID: | CAHut+Pv=-tUUciFZ-ujPuUovfaeNUWHOaEG0OL7kdcM6SwWWrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Kuroda-San, here are some review comment for patch v19-00001
======
doc/src/sgml/ref/alter_subscription.sgml
The previous patches have common failover/two_phase code checking for
"Do not allow changing the option if the subscription is enabled", but
it seems the docs were mentioning that only for "two_phase" and not
for "failover".
I'm not 100% sure if mentioning about disabled was necessary, but
certainly it should be all-or-nothing, not just saying it for one of
the parameters. Anyway, I chose to add the missing info. Please see
the attached nitpicks diff.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
| Attachment | Content-Type | Size |
|---|---|---|
| PS_NITPICKS_20240718_2PC_V190003.txt | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-07-18 00:31:18 | Re: Wrong results with grouping sets |
| Previous Message | Peter Smith | 2024-07-17 23:24:29 | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |