| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Slow catchup of 2PC (twophase) transactions on replica in LR |
| Date: | 2024-07-17 05:13:35 |
| Message-ID: | TYAPR01MB569240C3946E019FB419B6A3F5A32@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hou, Peter,
Thanks for giving comments! PSA new version.
Almost comments were addressed.
What's new:
0001 - IsTwoPhaseTransactionGidForSubid() was updated per comment from Hou-san [1].
Some nitpicks were accepted.
0002 - An argument in CheckAlterSubOption() was renamed to " slot_needs_update "
Some nitpicks were accepted.
0003 - Some nitpicks were accepted.
Below part contains the reason why I rejected some comments.
> CommonChecksForFailoverAndTwophase:
> nitpick - added Assert for the generic-looking "option" parameter name
The style looks strange for me, using multiple strcmp() is more straightforward.
Added like that.
> 1c.
> If the error checks can be moved to be done up-front, then all the 'needs_update'
> can be combined. Avoiding multiple checks to 'needs_update' will make this function simpler.
This style was needed to preserve error condition for failover option. Not changed.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v19-0001-Allow-altering-of-two_phase-option-of-a-SUBSCRIP.patch | application/octet-stream | 35.2 KB |
| v19-0002-Alter-slot-option-two_phase-only-when-altering-t.patch | application/octet-stream | 14.2 KB |
| v19-0003-Notify-users-to-roll-back-prepared-transactions.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2024-07-17 05:34:48 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Andrei Lepikhov | 2024-07-17 05:12:04 | Re: Expand applicability of aggregate's sortop optimization |