| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Slow catchup of 2PC (twophase) transactions on replica in LR |
| Date: | 2024-07-18 02:10:47 |
| Message-ID: | TYAPR01MB56928230D14570774D67F0C1F5AC2@TYAPR01MB5692.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Peter,
Thanks for giving comments! PSA new version.
I think most of comments were addressed, and I ran pgindent/pgperltidy again.
Regarding the CheckAlterSubOption(), the ordering is still preserved
because I preferred to keep some specs. But I can agree that yours
make codes simpler.
BTW, I started to think patches can be merged in future versions because
they must be included at once and codes are not so long. Thought?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0001-Allow-altering-of-two_phase-option-of-a-SUBSCRIP.patch | application/octet-stream | 35.6 KB |
| v20-0002-Alter-slot-option-two_phase-only-when-altering-t.patch | application/octet-stream | 14.0 KB |
| v20-0003-Notify-users-to-roll-back-prepared-transactions.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-07-18 02:22:16 | RE: Conflict detection and logging in logical replication |
| Previous Message | Richard Guo | 2024-07-18 02:02:50 | Redundant code in create_gather_merge_path |