Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Önder Kalacı <onderkalaci(at)gmail(dot)com>
Subject: Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
Date: 2023-07-17 03:17:40
Message-ID: CAHut+PupHavaYqxij+UwkXoYT_YJKzSaX7TNBaW+-Zwc034TrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 15, 2023 at 2:10 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Jul 14, 2023 at 2:15 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > > > I think it's appropriate to add on the restrictions page. (But mentioning that this
> > > restriction is only for subscriber)
> > > >
> > > > If the list were larger, then the restrictions page could be divided into publisher
> > > and subscriber restrictions. But not for one very specific restriction.
> > > >
> > >
> > > Okay, how about something like: "The UPDATE and DELETE operations
> > > cannot be applied on the subscriber for the published tables that
> > > specify REPLICA IDENTITY FULL when the table has attributes with
> > > datatypes (e.g point or box) that don't have a default operator class
> > > for Btree or Hash. This won't be a problem if the table has a primary
> > > key or replica identity defined for it."?
> >
> > Thanks for discussing and giving suggestions. But it seems that the first
> > sentence is difficult to read for me. How about attached?
> >
>
> The last line seems repetitive to me. So, I have removed it. Apart
> from that patch looks good to me. Sergie, Peter, and others, any
> thoughts?

The v5 patch LGTM.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2023-07-17 03:18:30 Re: unrecognized node type while displaying a Path due to dangling pointer
Previous Message Justin Pryzby 2023-07-17 02:37:28 Re: ALTER TABLE SET ACCESS METHOD on partitioned tables