| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL |
| Date: | 2023-07-17 06:21:12 |
| Message-ID: | CACawEhVQSpzHubFSKM=OVW_gtUDBTAc8h5=uV+MEVhaLgC6bbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
>
> > The last line seems repetitive to me. So, I have removed it. Apart
> > from that patch looks good to me. Sergie, Peter, and others, any
> > thoughts?
>
> The v5 patch LGTM.
>
>
Overall looks good to me as well. Please consider the following as an
optional improvement.
My only minor concern here is the use of the term "default operator class".
It is accurate to use it. However, as far as I know, not many users can
follow that easily. I think the "pkey/repl full" suggestion gives some tip,
but I wonder if we add something like the following to the text such that
users can understand more:
do not have a default operator class for B-tree or Hash.
+ If there is no default operator class, usually the type does not have an
> equality operator.
However, this limitation ..
Thanks,
Onder
| From | Date | Subject | |
|---|---|---|---|
| Next Message | suyu.cmj | 2023-07-17 06:26:56 | Re: The same 2PC data maybe recovered twice |
| Previous Message | Amit Kapila | 2023-07-17 05:41:01 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |