| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-07-20 05:08:36 |
| Message-ID: | CAHut+PumduU-8dpUdqoi0AxnCEhyUiewaVTCF2bZfg_sVStA+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 19, 2022 at 11:34 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Jul 18, 2022 at 9:46 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > I have updated the patch to handle the origin value case
> > insensitively. The attached patch has the changes for the same.
> >
>
> Thanks, the patch looks mostly good to me. I have made a few changes
> in 0001 patch which are as follows: (a) make a comparison of origin
> names in maybe_reread_subscription similar to slot names as in future
> we may support origin names other than 'any' and 'none', (b) made
> comment changes at few places and minor change in one of the error
> message, (c) ran pgindent and slightly changed the commit message.
>
> I am planning to push this day after tomorrow unless there are any
> comments/suggestions.
FYI, the function name in the comment is not same as the function name here:
+/*
+ * IsReservedName
+ * True iff name is either "none" or "any".
+ */
+static bool
+IsReservedOriginName(const char *name)
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-07-20 05:12:26 | Re: fix stats_fetch_consistency value in postgresql.conf.sample |
| Previous Message | Fujii Masao | 2022-07-20 05:00:00 | Re: Backup command and functions can cause assertion failure and segmentation fault |