| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Handle infinite recursion in logical replication setup |
| Date: | 2022-07-19 11:34:37 |
| Message-ID: | CAA4eK1J7cJPRhFfXOuhuxkYH_nwKE_LxDqzxEEO8EWZN2oA3Jg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 18, 2022 at 9:46 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> I have updated the patch to handle the origin value case
> insensitively. The attached patch has the changes for the same.
>
Thanks, the patch looks mostly good to me. I have made a few changes
in 0001 patch which are as follows: (a) make a comparison of origin
names in maybe_reread_subscription similar to slot names as in future
we may support origin names other than 'any' and 'none', (b) made
comment changes at few places and minor change in one of the error
message, (c) ran pgindent and slightly changed the commit message.
I am planning to push this day after tomorrow unless there are any
comments/suggestions.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v35-0001-Allow-uses-to-skip-logical-replication-of-data-h.patch | application/octet-stream | 61.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-07-19 11:40:11 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |
| Previous Message | Antonin Houska | 2022-07-19 11:33:16 | Re: Proposal: allow database-specific role memberships |