| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skip collecting decoded changes of already-aborted transactions |
| Date: | 2025-02-12 05:43:12 |
| Message-ID: | CAHut+Pu8Eqc35OmK_uaC=NFtqOn=bVhrYvVrcJ_ewBkcZx77+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi. Here are some minor comments for the v18* patch set.
//////////
Patch v18-0001
1.1. Commit message
A previously reported typo still exists:
/noticeble/noticeable/
//////////
Patch v18-0002
2.1
+#define RBTXN_PREPARE_STATUS_FLAGS (RBTXN_IS_PREPARED |
RBTXN_SKIPPED_PREPARE | RBTXN_SENT_PREPARE)
+
AFAICT bitmasks like this are more commonly named with a _MASK suffix.
How about something like:
- RBTXN_PREPARE_MASK
- RBTXN_PREPARE_STATUS_MASK
- RBTXN_PREPARE_FLAGS_MASK
==========
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2025-02-12 05:47:47 | Re: EvictUnpinnedBuffer and buffer free list |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-02-12 05:36:01 | RE: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value. |