| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Skip collecting decoded changes of already-aborted transactions |
| Date: | 2025-02-13 01:58:12 |
| Message-ID: | CAD21AoAFTS65BTfyawtiQ2hhV-iMSBpToUaCd3Ja6WUwN5PNKg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 11, 2025 at 9:43 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi. Here are some minor comments for the v18* patch set.
>
> //////////
>
> Patch v18-0001
>
> 1.1. Commit message
>
> A previously reported typo still exists:
>
> /noticeble/noticeable/
>
> //////////
>
> Patch v18-0002
>
> 2.1
> +#define RBTXN_PREPARE_STATUS_FLAGS (RBTXN_IS_PREPARED |
> RBTXN_SKIPPED_PREPARE | RBTXN_SENT_PREPARE)
> +
>
> AFAICT bitmasks like this are more commonly named with a _MASK suffix.
>
> How about something like:
> - RBTXN_PREPARE_MASK
> - RBTXN_PREPARE_STATUS_MASK
> - RBTXN_PREPARE_FLAGS_MASK
>
Pushed both patches after addressing the above comments. Thank you for
your review!
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-02-13 02:50:08 | Re: [PATCH] Optionally record Plan IDs to track plan changes for a query |
| Previous Message | John Naylor | 2025-02-13 01:49:41 | Re: Change GUC hashtable to use simplehash? |