| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: pg_rewind with --write-recovery-conf option doesn't write dbname to primary_conninfo value. |
| Date: | 2025-02-12 05:36:01 |
| Message-ID: | OSCPR01MB149663B66E27A4028EC609651F5FC2@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san,
Thanks for updating the patch!
> I've attached the updated patch. I address all comments I got so far
> and added a small regression test.
>
> It makes sense to me that we move GetDbnameFromConnectionOptions() to
> recovery_gen.c since this function is currently used only with
> GenerateRecoveryConfig() which is defined in the same file. If we find
> a more appropriate place, we can move it later. Feedback is very
> welcome.
I considered your idea that adding new API, but it seemed for me to have less
benefit. Also, I do not know better place for the declaration now. Overall, the
patch looks good to me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-02-12 05:43:12 | Re: Skip collecting decoded changes of already-aborted transactions |
| Previous Message | Shlok Kyal | 2025-02-12 05:23:37 | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |