Re: checkpoint_flush_after documentation inconsistency

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: checkpoint_flush_after documentation inconsistency
Date: 2016-04-25 04:57:57
Message-ID: CAHGQGwHCUBNj09Mv1VpQgG-4NZon8eWZCgctba4sbb5_07QTdA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 25, 2016 at 4:27 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-04-21 11:20:38 -0700, Andres Freund wrote:
>> On 2016-04-18 14:33:28 +0900, Fujii Masao wrote:
>> > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> > > The documentation says that the default value is 128Kb on Linux, but the
>> > > code says it's 256Kb.
>> > >
>> > > Not sure which one is correct, but the other one should be updated :) I'm
>> > > guessing it's a copy/paste mistake in the docs, but since I'm not sure I'm
>> > > not just pushing a fix.
>> >
>> > I think you're right.
>> >
>> > I also found another several small problems regarding XXX_flush_after
>> > parameters.
>>
>> Thanks for finding these, once I'm back home/office from pgconf.nyc
>> (tonight / tomorrow) I'll push a fix.
>
> Pushed a fix, could you check that you're ok with the result?

The fix looks good to me. Thanks!

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2016-04-25 05:07:23 Re: Ordering in guc.c vs. config.sgml vs. postgresql.sample.conf
Previous Message Stephen Frost 2016-04-25 04:39:09 Re: pg_dump dump catalog ACLs