Re: checkpoint_flush_after documentation inconsistency

From: Andres Freund <andres(at)anarazel(dot)de>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: checkpoint_flush_after documentation inconsistency
Date: 2016-04-24 19:27:26
Message-ID: 20160424192726.3rrqmews4usiytsl@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-04-21 11:20:38 -0700, Andres Freund wrote:
> On 2016-04-18 14:33:28 +0900, Fujii Masao wrote:
> > On Fri, Apr 15, 2016 at 6:56 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> > > The documentation says that the default value is 128Kb on Linux, but the
> > > code says it's 256Kb.
> > >
> > > Not sure which one is correct, but the other one should be updated :) I'm
> > > guessing it's a copy/paste mistake in the docs, but since I'm not sure I'm
> > > not just pushing a fix.
> >
> > I think you're right.
> >
> > I also found another several small problems regarding XXX_flush_after
> > parameters.
>
> Thanks for finding these, once I'm back home/office from pgconf.nyc
> (tonight / tomorrow) I'll push a fix.

Pushed a fix, could you check that you're ok with the result?

Also started http://archives.postgresql.org/message-id/20160424185814.n3nj2ahlutoykfou%40
to discuss making the ordering of config variables more consistent.

Thanks Magnus and Fujii

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christian Ullrich 2016-04-24 19:27:32 Re: VS 2015 support in src/tools/msvc
Previous Message Andrew Dunstan 2016-04-24 19:23:59 Re: VS 2015 support in src/tools/msvc