From: | Sehrope Sarkuni <sehrope(at)jackdb(dot)com> |
---|---|
To: | Dave Cramer <davecramer(at)gmail(dot)com> |
Cc: | List <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: Reviewers needed for pgjdbc pull requests |
Date: | 2018-05-15 14:22:16 |
Message-ID: | CAH7T-ap3URUjUaPhjCFWesEM+4h7UKAk0MQ--sq8aB2xBPb3wQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
On Tue, May 15, 2018 at 9:45 AM, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> There are quite a few pull requests on the github project
> https://github.com/pgjdbc/pgjdbc/pulls
>
Wow 72 open and 20+ since Jan of this year. On the flip side the activity
level is also pretty impressive!
> Most of the work fall on Vladimir and I try to do some as well.
>
And we thank you both! :D
> I'm looking for suggestions on how to deal with this. Clearly pull
> requests become stale if they are not dealt with quickly.
>
> One thought is that if you have an existing PR that you want pushed then
> pick up another to review.
>
I wouldn't say imposing it as a rule but *strongly* encouraged would be
nice.
> I'm open to suggestions?
>
Might be able to arrange things a bit better with more tagging. There's a
bit of it for some of the older PRs but none of the recent ones have any
tags applied.
It adds some work on the part of the organizer but may allow more people to
get involved as simpler items could be more easily found.
Rather than imposing this as more work on the the repo owners it could be
part of the PR template itself. That way the repo owner (or someone else
given tagging permissions) could apply them quickly without having to
actually review the entire PR.
Having a bit more structure or guidelines for the review process would be
nice too. If people know that passing an objective third party review will
grant an audience from a committer, I think it'd welcome more reviews and
they'd seek those reviews themselves (i.e. find someone to help review
their PR).
-S
From | Date | Subject | |
---|---|---|---|
Next Message | Sehrope Sarkuni | 2018-05-15 14:27:31 | Re: Reviewers needed for pgjdbc pull requests |
Previous Message | Dave Cramer | 2018-05-15 14:04:46 | Re: Reviewers needed for pgjdbc pull requests |