From: | Dave Cramer <davecramer(at)gmail(dot)com> |
---|---|
To: | Zemian Deng <zemiandeng(at)gmail(dot)com> |
Cc: | List <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: Reviewers needed for pgjdbc pull requests |
Date: | 2018-05-15 14:04:46 |
Message-ID: | CADK3HH+mR6niumeA-Z=EKLqe35BDjG-pwHZ3xab9vaqoEqzN_g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
hmmm well there's a good start since we don't have a PR acceptance process.
Clearly it has to pass the CI tests, but other than that we don't have a
clear process.
Sounds like that is step 1.
Are there examples from other projects ?
Dave Cramer
On 15 May 2018 at 10:00, Zemian Deng <zemiandeng(at)gmail(dot)com> wrote:
> Hi Dave, I will be happy to help out some if you can tell me little more
> about your PR acceptance process.
>
> — Zemian
>
> On May 15, 2018, at 9:45 AM, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>
> There are quite a few pull requests on the github project
> https://github.com/pgjdbc/pgjdbc/pulls
>
> Most of the work fall on Vladimir and I try to do some as well.
>
> I'm looking for suggestions on how to deal with this. Clearly pull
> requests become stale if they are not dealt with quickly.
>
> One thought is that if you have an existing PR that you want pushed then
> pick up another to review.
>
> I'm open to suggestions?
>
> Dave Cramer
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Sehrope Sarkuni | 2018-05-15 14:22:16 | Re: Reviewers needed for pgjdbc pull requests |
Previous Message | Robert Zenz | 2018-05-15 14:04:41 | Re: Reviewers needed for pgjdbc pull requests |