From: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>, Shirley Wang <swang(at)pivotal(dot)io> |
Subject: | Re: [patch] Query Output Header Width |
Date: | 2017-04-24 13:43:29 |
Message-ID: | CAGRPzo9WUy4CAGCzhzNm-R2ak-rm1sBKFLBCmO85Vw8MgNdCmw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Oh, good catch! Here's a new patch with all the lines in place.
Thanks,
Joao & Sarah
On Thu, Apr 20, 2017 at 12:05 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili <
> ggelashvili(at)pivotal(dot)io> wrote:
>
>> Hello Hackers,
>>
>> We found that having the column header extend all the way across the
>> query output frame made it seem like there were more columns. This was
>> confusing to some users.
>>
>> We made a change to the column header styling so it ends with the
>> rightmost column.
>>
>> Happy Friday!
>> Matt & Shirley & George
>>
>
> Hi Matt & Shirley & George!
>
> I agree with the basic premise of this patch, however it has the
> side-effect of removing the bottom border from the entire header row, which
> makes the transition from the header ro to the first data row look very odd
> (especially in the first row header, which essentially merges into the
> top-left "select all" cell). Screenshot attached.
>
> Can you get the line back in place, but so it only shows up under the
> actual header cells?
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
Attachment | Content-Type | Size |
---|---|---|
0001-Make-output-header-align-right.patch | application/octet-stream | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-04-24 19:27:04 | pgAdmin 4 commit: Only display the header row in SlickGrid where column |
Previous Message | Sarah McAlear | 2017-04-24 13:38:04 | Re: [patch] Move to Alembic migration system |