Re: [patch] Query Output Header Width

From: Dave Page <dpage(at)pgadmin(dot)org>
To: George Gelashvili <ggelashvili(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>, Shirley Wang <swang(at)pivotal(dot)io>
Subject: Re: [patch] Query Output Header Width
Date: 2017-04-20 16:05:35
Message-ID: CA+OCxoz1je+REL5ckw9Vv2r1yHKVFYgyF86Y_az94c-g4eQG0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:

> Hello Hackers,
>
> We found that having the column header extend all the way across the query
> output frame made it seem like there were more columns. This was confusing
> to some users.
>
> We made a change to the column header styling so it ends with the
> rightmost column.
>
> Happy Friday!
> Matt & Shirley & George
>

Hi Matt & Shirley & George!

I agree with the basic premise of this patch, however it has the
side-effect of removing the bottom border from the entire header row, which
makes the transition from the header ro to the first data row look very odd
(especially in the first row header, which essentially merges into the
top-left "select all" cell). Screenshot attached.

Can you get the line back in place, but so it only shows up under the
actual header cells?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
image/png 32.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Shirley Wang 2017-04-20 18:39:53 Re: [Design update] Style guide for pgAdmin4
Previous Message Ashesh Vashi 2017-04-20 14:56:40 Re: [patch] Move to Alembic migration system