From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
Cc: | George Gelashvili <ggelashvili(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Matthew Kleiman <mkleiman(at)pivotal(dot)io>, Shirley Wang <swang(at)pivotal(dot)io> |
Subject: | Re: [patch] Query Output Header Width |
Date: | 2017-04-24 19:27:13 |
Message-ID: | CA+OCxoxwgau=fuZwtN3XgzQjFfFJUWAZrZ23j-BSR45hObRZMQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks - patch applied!
On Mon, Apr 24, 2017 at 2:43 PM, Sarah McAlear <smcalear(at)pivotal(dot)io> wrote:
> Oh, good catch! Here's a new patch with all the lines in place.
>
> Thanks,
> Joao & Sarah
>
> On Thu, Apr 20, 2017 at 12:05 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Fri, Apr 14, 2017 at 11:01 PM, George Gelashvili <
>> ggelashvili(at)pivotal(dot)io> wrote:
>>
>>> Hello Hackers,
>>>
>>> We found that having the column header extend all the way across the
>>> query output frame made it seem like there were more columns. This was
>>> confusing to some users.
>>>
>>> We made a change to the column header styling so it ends with the
>>> rightmost column.
>>>
>>> Happy Friday!
>>> Matt & Shirley & George
>>>
>>
>> Hi Matt & Shirley & George!
>>
>> I agree with the basic premise of this patch, however it has the
>> side-effect of removing the bottom border from the entire header row, which
>> makes the transition from the header ro to the first data row look very odd
>> (especially in the first row header, which essentially merges into the
>> top-left "select all" cell). Screenshot attached.
>>
>> Can you get the line back in place, but so it only shows up under the
>> actual header cells?
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2017-04-25 04:59:19 | [pgAdmin4][PATCH] To fix the issue of default parameters ordering in Functions |
Previous Message | Dave Page | 2017-04-24 19:27:04 | pgAdmin 4 commit: Only display the header row in SlickGrid where column |