| From: | Anthony Emengo <aemengo(at)pivotal(dot)io> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item |
| Date: | 2018-05-02 18:25:33 |
| Message-ID: | CAG8BBZPusSpR4xjvH-=OEW2RDejW=jgv3JyviyyY6Gb9ee425Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Forgive me but please consider the following patch instead - as it better
adheres to the python style guide.
On Wed, May 2, 2018 at 12:43 PM Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:
> Hi Hackers,
>
> Please find the attached patch to fix the RM #3324 : user cannot load
> “External Tables” on the navigation pane.
>
> The issue was that ultimately paths were not being cleaned after being
> munged from the “template” input which would result in template_paths that
> resembled: path//to//dir.sql. These would work on unix based systems but
> lead to complication on Windows.
>
> The following patch resolves this issue, and also included a small file
> refactor to better convey developer intent.
>
> Thanks,
> Anthony
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-fix-external-tables-on-windows-2.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2018-05-03 05:58:35 | Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel |
| Previous Message | Anthony Emengo | 2018-05-02 16:43:48 | [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item |