Re: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item

Thanks, patch applied!

On Wed, May 2, 2018 at 7:25 PM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:

> Forgive me but please consider the following patch instead - as it better
> adheres to the python style guide.
>
> On Wed, May 2, 2018 at 12:43 PM Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch to fix the RM #3324 : user cannot load
>> “External Tables” on the navigation pane.
>>
>> The issue was that ultimately paths were not being cleaned after being
>> munged from the “template” input which would result in template_paths that
>> resembled: path//to//dir.sql. These would work on unix based systems but
>> lead to complication on Windows.
>>
>> The following patch resolves this issue, and also included a small file
>> refactor to better convey developer intent.
>>
>> Thanks,
>> Anthony
>> ​
>>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company