Re: [pgAdmin4][patch] - Fix CheckForViewDataTest

Hi

On Thu, May 3, 2018 at 3:23 PM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:

> Hi Hackers,
>
> The feature test at pgadmin4/web/pgadmin/feature_
> tests/view_data_dml_queries.py systematically fails in both our CI
> pipelines and when run locally. It seems to be because the selenium driver
> is unable to parse cells of the query result table when is it out of view.
> This issue seemed to have occurred after our most recent changes to how the
> feature tests run got committed into master.
> ​
> [image: Screen Shot 2018-05-03 at 10.15.55 AM.png]
>
> Please consider the following patch to remedy this issue.
>

Thanks for looking at this - I was about to do so myself.

I'm not sure that maximising the window is the answer unfortunately. For
example, the machine I'm hitting this with at the moment is a Mac which is
essentially running headless (albeit connected to a KVM in a rack), which
only wants to run at 800x600 resolution. I had hoped that the patch I
committed yesterday to enable headless mode would solve that, but
unfortunately not (it did solve some other issues I had running under a
macOS Jenkins worker node, hence I committed it anyway). The other machine
I hit this issue on is my travel laptop, which typically runs at 1024 x 640
or 1280 x 800 effective resolution.

Can we either ensure the cell is scrolled into view before the value is
read, or limit the number of columns we render in the affected tests
(perhaps by splitting them into multiple tests)?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company