[pgAdmin4][patch] - Fix CheckForViewDataTest

From: Anthony Emengo <aemengo(at)pivotal(dot)io>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][patch] - Fix CheckForViewDataTest
Date: 2018-05-03 14:23:21
Message-ID: CAG8BBZPi680AXzYqG4E43Fm0Gbz1S8U_cg-v+tRGs5DgBvtmKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

The feature test at
pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py systematically
fails in both our CI pipelines and when run locally. It seems to be because
the selenium driver is unable to parse cells of the query result table when
is it out of view. This issue seemed to have occurred after our most recent
changes to how the feature tests run got committed into master.

[image: Screen Shot 2018-05-03 at 10.15.55 AM.png]

Please consider the following patch to remedy this issue.

Thanks,
Anthony

Attachment Content-Type Size
0001-fix-check_for-view-data-test.patch application/octet-stream 673 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-05-03 14:54:19 pgAdmin 4 commit: Fix the template loader to work reliably under Window
Previous Message Anthony Emengo 2018-05-03 12:23:01 Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.