[pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item

From: Anthony Emengo <aemengo(at)pivotal(dot)io>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item
Date: 2018-05-02 16:43:48
Message-ID: CAG8BBZMg7JS1=vfa+Y7qTLpgWOw4CuCyYQTHPX4ZYj+e6_Ky8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Please find the attached patch to fix the RM #3324 : user cannot load
“External Tables” on the navigation pane.

The issue was that ultimately paths were not being cleaned after being
munged from the “template” input which would result in template_paths that
resembled: path//to//dir.sql. These would work on unix based systems but
lead to complication on Windows.

The following patch resolves this issue, and also included a small file
refactor to better convey developer intent.

Thanks,
Anthony

Attachment Content-Type Size
0001-fix-external-tables-on-windows.patch application/octet-stream 4.4 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Anthony Emengo 2018-05-02 18:25:33 Re: [pgAdmin4][RM#3324] - Windows user unable to expand "External Tables" navigation item
Previous Message Dave Page 2018-05-02 15:51:23 pgAdmin 4 commit: Allow feature tests to run in Chrome headless mode.