From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixes for pgAdmin4 messages |
Date: | 2017-11-04 04:05:07 |
Message-ID: | CAG7mmoz+BtAom+YKXmYyLYykZdwOZPAZL81eTeuU02yzAXy3ZQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Looks like - the patch has introduced syntax error in database.js.
On Nov 3, 2017 22:19, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> Unfortunately I've had to revert this. It was causing the treeview to
> render incorrectly (see the attached screenshot).
>
> Can you take a look please? I've CC'd Ashesh as he knows that area of the
> code far better than I do and may be able to spot the issue much more
> quickly (plus I'm travelling from tomorrow AM, and will have limited
> availability).
>
> On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, patch applied.
>>
>> On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion(at)gmail(dot)com>
>> wrote:
>>
>>> Hello,
>>> I have another patch for the better localization of pgAdmin4.
>>> Please consider applying it.
>>>
>>> Best regards,
>>> ------
>>> Alexander Lakhin
>>> Postgres Professional: http://www.postgrespro.com
>>> The Russian Postgres Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Lakhin | 2017-11-04 06:25:31 | Re: Fixes for pgAdmin4 messages |
Previous Message | Dave Page | 2017-11-03 16:54:17 | Re: [pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data |