Re: Fixes for pgAdmin4 messages

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: Fixes for pgAdmin4 messages
Date: 2017-11-03 16:49:46
Message-ID: CA+OCxoxJ12Rfr251WS-C_Oh75BzUvh=sDwrL9S72=KEtSNCwhg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Unfortunately I've had to revert this. It was causing the treeview to
render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the
code far better than I do and may be able to spot the issue much more
quickly (plus I'm travelling from tomorrow AM, and will have limited
availability).

On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied.
>
> On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion(at)gmail(dot)com>
> wrote:
>
>> Hello,
>> I have another patch for the better localization of pgAdmin4.
>> Please consider applying it.
>>
>> Best regards,
>> ------
>> Alexander Lakhin
>> Postgres Professional: http://www.postgrespro.com
>> The Russian Postgres Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
image/png 21.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-11-03 16:52:32 Re: [pgAdmin4][Patch]: Fixed RM 2844 Tree View Icons
Previous Message Dave Page 2017-11-03 16:46:19 pgAdmin 4 commit: Revert "Fix a number of cases where strings were not