Re: [pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed RM 2830 Corrupts type CHAR(4) data
Date: 2017-11-03 16:54:17
Message-ID: CA+OCxozHy5URJ7z2mj6P-asU34kExTodzdJ=gyixhnBPL=sB=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ashesh, can you review/commit please? Please remember to test sized vs.
unsized columns, as well as "char" and char etc.

Thanks!

On Fri, Nov 3, 2017 at 10:12 AM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:

> Hi All
>
> Attached is the patch file to fix RM #2830 "Corrupts type CHAR(4) data".
> During that I found one more issue where message "Data saved successfully."
> popped up even if there is an error while saving the data. I have fixed
> that too.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-11-04 04:05:07 Re: Fixes for pgAdmin4 messages
Previous Message pgAdmin 4 Jenkins 2017-11-03 16:52:55 Build failed in Jenkins: pgadmin4-master-python26 #496