ESLINT: On pgAdmin static javascripts

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: ESLINT: On pgAdmin static javascripts
Date: 2018-01-08 13:55:27
Message-ID: CAG7mmoyMuRw2eACo22vTX_FjYNCVOQA_u8MUpT=G7wwM2vMoCw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave/Team,

I found many problems while 'eslint' utility on all the static javascript
files of pgAdmin 4.
i.e. <pgAdmin4_path>/web/node_module/.bin/eslint <file_name>

I had fixed all errors reported by eslint for those files.

I have created six patches for ease of maintenance, as possibilities of
conflicting with other patches.
* Browser nodes javascript files
* Browser specific javascript files
* pgAdmin common javascript files
* SQLEditor/DataGrid javascript files
* Tools javascript files
* Miscellaneous modules javascript files

All patches are independent of each other.

Please review it, and share your opinion.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

Attachment Content-Type Size
pgadmin_misc_eslint_v1.patch application/octet-stream 388.7 KB
pgadmin_browser_static_eslint_v1.patch application/octet-stream 320.6 KB
pgadmin_browser_nodes_eslint_v1.patch application/octet-stream 1.0 MB
pgadmin_common_eslint_v1.patch application/octet-stream 239.7 KB
pgadmin_sqleditor_eslint_v1.patch application/octet-stream 192.2 KB
pgadmin_tools_eslint_v1.patch application/octet-stream 503.9 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-01-08 13:56:24 Re: [pgAdmin4][Patch]: Adding connection status in Query tool
Previous Message Dave Page 2018-01-08 13:51:14 Re: [pgAdmin4][Patch]: Adding connection status in Query tool