Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Wenlin Zhang <wzhang(at)pivotal(dot)io>
Cc: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment
Date: 2017-08-09 11:26:47
Message-ID: CAG7mmox4+8FztW-G=N8uCn4x0AqhF=codFUod_ia8+C5kZe8JQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Aug 9, 2017 at 8:55 AM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:

> Hi Surinder,
>
> This is great and useful. Looks good to me. Hope this can be committed
> ASAP.
>
Thanks!
Committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> Thanks,
>
> Wenlin & Violet
>
>
>
> On Wed, Aug 2, 2017 at 9:41 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi All,
>>
>> This patch enables source maps in pgAdmin4 for development environment.
>>
>> On running yarn run bundle It will create source maps(i.e. extract each
>> module js file so that it is available to debug).
>>
>> You can search each module(ie. menu.js to debug) file by filename as
>> follows:
>>
>> 1.
>>
>> Start pgAdmin4 server or run separately yarn run bundle in pgadmin/web
>> 2.
>>
>> Open pgAdmin4 in browser(I am using chrome). Click sources panel and
>> press CMD+P and search for file menu.js. Click and then add
>> breakpoint to the line where you want to debug codebase. Screenshot
>> attached for reference.
>>
>> I have excluded vendor and codemirror bundle from source map as i
>> believe we don’t debug these files. If someone needs, they can remove
>> vendor.js from source map plugin and rebuild.
>>
>> I didn’t add this for production mode yet.
>>
>> Reference to SourceMapDevToolPlugin
>> <https://webpack.js.org/plugins/source-map-dev-tool-plugin/#components/sidebar/sidebar.jsx>
>>
>> Please find attached patch and review.
>>
>> Thanks,
>> Surinder
>> ​
>>
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2017-08-09 11:30:48 Build failed in Jenkins: pgadmin4-master-python27 #279
Previous Message Ashesh Vashi 2017-08-09 11:26:08 Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues