Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

From: Wenlin Zhang <wzhang(at)pivotal(dot)io>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment
Date: 2017-08-09 03:25:28
Message-ID: CAEawo3+DQjeMkztNZzx9OXtXmDK-i_PJJR4gKD4jnkhP7GeJ7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Surinder,

This is great and useful. Looks good to me. Hope this can be committed
ASAP.

Thanks,

Wenlin & Violet

On Wed, Aug 2, 2017 at 9:41 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi All,
>
> This patch enables source maps in pgAdmin4 for development environment.
>
> On running yarn run bundle It will create source maps(i.e. extract each
> module js file so that it is available to debug).
>
> You can search each module(ie. menu.js to debug) file by filename as
> follows:
>
> 1.
>
> Start pgAdmin4 server or run separately yarn run bundle in pgadmin/web
> 2.
>
> Open pgAdmin4 in browser(I am using chrome). Click sources panel and
> press CMD+P and search for file menu.js. Click and then add breakpoint
> to the line where you want to debug codebase. Screenshot attached for
> reference.
>
> I have excluded vendor and codemirror bundle from source map as i believe
> we don’t debug these files. If someone needs, they can remove vendor.js
> from source map plugin and rebuild.
>
> I didn’t add this for production mode yet.
>
> Reference to SourceMapDevToolPlugin
> <https://webpack.js.org/plugins/source-map-dev-tool-plugin/#components/sidebar/sidebar.jsx>
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
> ​
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-08-09 03:27:21 Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module
Previous Message Sarah McAlear 2017-08-09 03:20:21 Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies