Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues
Date: 2017-08-09 11:26:08
Message-ID: CAG7mmozrKTPTiexjjzV48r3=b7QseAVpATG9BfitwiFQJZ8iQg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Wed, Aug 9, 2017 at 3:32 PM, Harshal Dhumal <
harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:

>
> On Fri, Aug 4, 2017 at 6:32 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Harshal,
>>
>> On Fri, Jul 28, 2017 at 4:00 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Ashesh, can you deal with this please? Thanks.
>>>
>>> On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the RM #2603: Import/Export File
>>>> issues.
>>>>
>>>
>>>> Fixed Issues:
>>>> 1. Couldn't click on the File Control once gets an error
>>>> 2. The encoding is not in alphabetical order
>>>>
>>> Please review it.
>>
>
> It looks good to me.
>
Thanks!

Committed the patch!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

>
> thanks,
>
>
>>
>> -- Thanks, Ashesh
>>
>>>
>>>> Thanks,
>>>> Khsuhboo
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-08-09 11:26:47 Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment
Previous Message Ashesh Vashi 2017-08-09 11:25:34 Re: [gpAdmin4][patch] query history updates