Re: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder
Date: 2016-05-14 10:14:19
Message-ID: CAG7mmowj0FddiZT-UDfeb9UjyPgCcyCotsQj=e8q3U=wBqYh+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Fri, May 6, 2016 at 4:32 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to fix the issue:
> Unable to create extension "postgis_topology" and
> "postgis_tiger_geocoder", due to wrong schema name in generated SQL query.
>
> *For example*:
>
> It generates following query for '*postgis_toplology*' extension:
> CREATE EXTENSION *postgis_topology* SCHEMA *topology*;
>
> which is wrong. the correct query should be:
> CREATE EXTENSION *postgis_topology*;
>
> where it fetches '*topology*' schema from table *pg_available_extensions*
> and
> then sets schema when extension name is selected, but it should not set
> schema on name change.
> It is now fixed in this patch.
> Thanks Fahar for reporting.
>
> Please review and let me know for comments.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-05-14 10:15:27 Re: [pgAdmin4][Patch]: Load/Save file in query tool
Previous Message Ashesh Vashi 2016-05-14 10:13:18 pgAdmin 4 commit: Fixed an issue creating extensions 'postgis_topology'